ruanhang1993 commented on a change in pull request #17994:
URL: https://github.com/apache/flink/pull/17994#discussion_r782782134
##########
File path:
flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/table/KafkaConnectorOptions.java
##########
@@ -158,6 +158,13 @@
.withDescription(
"Optional offsets used in case of
\"specific-offsets\" startup mode");
+ public static final ConfigOption<String> SCAN_BOUNDED_SPECIFIC_OFFSETS =
+ ConfigOptions.key("scan.bounded.specific-offsets")
+ .stringType()
+ .noDefaultValue()
+ .withDescription(
+ "When all partitions have reached their stop
offsets, the source will exit");
+
public static final ConfigOption<Long> SCAN_STARTUP_TIMESTAMP_MILLIS =
Review comment:
`scan.startup.mode` has nothing to do with end logic.
I suggest to provide a `scan.bounded.stop-mode` table option.
If it is `timestamp`, use `TimestampOffsetsInitializer` for the
`stoppingOffsetsInitializer` in the `KafkaSourceBuilder`.
If it is `specific-offsets`, use `SpecifiedOffsetsInitializer` for the
`stoppingOffsetsInitializer` in the `KafkaSourceBuilder`.
Or else it will be the `NoStoppingOffsetsInitializer` by default.
Besides, we need to check the corresponding setting for different modes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
