dmvk commented on a change in pull request #18332:
URL: https://github.com/apache/flink/pull/18332#discussion_r783078659



##########
File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniCluster.java
##########
@@ -1175,6 +1185,31 @@ private void terminateMiniClusterServices() throws 
Exception {
         }
     }
 
+    /**
+     * Prevent multiple submission of the same JobGraph that has been mutated 
in between

Review comment:
       Yes it should be as the job graph needs to send over the network so it's 
effectively cloned, so any mutations to the JobGraph on the client side 
wouldn't affect the instance used by Dispatcher.
   
   As I've already suggested, the other option would be simply cloning the job 
graph here.
   
   @zentol do you have any thoughts on this one?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to