[
https://issues.apache.org/jira/browse/FLINK-4247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15393949#comment-15393949
]
ASF GitHub Bot commented on FLINK-4247:
---------------------------------------
GitHub user twalthr opened a pull request:
https://github.com/apache/flink/pull/2298
[FLINK-4247] [table] CsvTableSource.getDataSet() expects Java
ExecutionEnvironment
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your
pull request. For more information and/or questions please refer to the [How To
Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful
description of your changes.
- [x] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira
title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the
JIRA id)
- [x] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [x] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis
build has passed
Adds explicit notice to `getDataSet/getDataStream` methods of `TableSource`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/twalthr/flink FLINK-4247
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2298.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2298
----
commit 03325bc1afa65566b4ee06dca5362e283052deb0
Author: twalthr <twal...@apache.org>
Date: 2016-07-26T15:27:02Z
[FLINK-4247] [table] CsvTableSource.getDataSet() expects Java
ExecutionEnvironment
----
> CsvTableSource.getDataSet() expects Java ExecutionEnvironment
> -------------------------------------------------------------
>
> Key: FLINK-4247
> URL: https://issues.apache.org/jira/browse/FLINK-4247
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
> Affects Versions: 1.1.0
> Reporter: Till Rohrmann
> Priority: Minor
>
> The Table API offers the {{CsvTableSource}} which can be used with the Java
> and Scala API. However, if used with the Scala API where on has obtained a
> {{scala.api.ExecutionEnvironment}} there is a problem with the
> {{CsvTableSource.getDataSet}} method. The method expects a
> {{java.api.ExecutionEnvironment}} to extract the underlying {{DataSet}}.
> Additionally it returns a {{java.api.DataSet}} instead of a
> {{scala.api.DataSet}}. I think we should also offer a Scala API specific
> CsvTableSource which works with the respective Scala counterparts.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
