Github user mbalassi commented on the issue:

    https://github.com/apache/flink/pull/2299
  
    The code change is very concise and looks right, the one issue that bugs me 
is that there are no direct tests in place to verify it - and it is not 
necessarily straight forward to test as it is a resource leak issue.
    
    I tried building the project locally and in fact `PythonPlanBinderTest` 
that uses the change transitively got stuck, but I could not manage to 
reproduce the issue when running solely that test from IntelliJ.
    
    I have fired up a travis test myself and the PR is also triggering one, let 
us whether those go through.
    
    @nssalian do you see a straight forward way to test the behaviour? 
    
    PS: Could you enabled the travis build on your repo, please? (As Flink 
comes with a travis.yml all you need to do is to go to Travis, login with your 
github user and hit enable on the repo.) 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to