[ 
https://issues.apache.org/jira/browse/FLINK-4259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394917#comment-15394917
 ] 

ASF GitHub Bot commented on FLINK-4259:
---------------------------------------

Github user nssalian commented on the issue:

    https://github.com/apache/flink/pull/2299
  
    hi @mbalassim thank you for the review. I have kicked off a build for my 
flink repo. Let me observe what happens.
    With regards to a test, I was thinking something on the lines  of 
FileCacheDeleteValidationTest.java with creating and checking whether the 
output stream is closed. 


> Unclosed FSDataOutputStream in FileCache#copy()
> -----------------------------------------------
>
>                 Key: FLINK-4259
>                 URL: https://issues.apache.org/jira/browse/FLINK-4259
>             Project: Flink
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Neelesh Srinivas Salian
>            Priority: Minor
>
> {code}
>         try {
>           FSDataOutputStream lfsOutput = tFS.create(targetPath, false);
>           FSDataInputStream fsInput = sFS.open(sourcePath);
>           IOUtils.copyBytes(fsInput, lfsOutput);
> {code}
> The FSDataOutputStream lfsOutput should be closed upon exit.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to