slinkydeveloper commented on a change in pull request #18370: URL: https://github.com/apache/flink/pull/18370#discussion_r784944167
########## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/ObjectIdentifier.java ########## @@ -42,50 +45,88 @@ @PublicEvolving public final class ObjectIdentifier implements Serializable { - private final String catalogName; - - private final String databaseName; + static final String UNKNOWN = "<UNKNOWN>"; Review comment: It's used in the tests, and i think package private doesn't hurt -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org