zentol commented on a change in pull request #18083:
URL: https://github.com/apache/flink/pull/18083#discussion_r785426976
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/entrypoint/ClusterEntrypoint.java
##########
@@ -558,9 +587,29 @@ private Configuration
generateClusterConfiguration(Configuration configuration)
* @throws IOException if the temporary directories could not be cleaned up
*/
protected void cleanupDirectories() throws IOException {
+ IOException ioException = null;
+
final String webTmpDir = configuration.getString(WebOptions.TMP_DIR);
Review comment:
The issue is that it is _not_ cleaned up on PROCESS_FAILURE, and a
restarted JM has no knowledge of the previous `webTmpDir` (so we're just
leaking it)..
Even if the webTmpDir were to be placed by default in the working directory,
it should still always be cleaned up on the off-chance that a user has
explicitly configured WebOptions.TMP_DIR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
