slinkydeveloper commented on a change in pull request #18349:
URL: https://github.com/apache/flink/pull/18349#discussion_r785834280
##########
File path:
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/connectors/DynamicSourceUtils.java
##########
@@ -80,28 +79,28 @@ public static RelNode convertDataStreamToRel(
boolean isBatchMode,
ReadableConfig config,
FlinkRelBuilder relBuilder,
- ObjectIdentifier identifier,
- ResolvedSchema schema,
+ ContextResolvedTable contextResolvedTable,
DataStream<?> dataStream,
DataType physicalDataType,
boolean isTopLevelRecord,
ChangelogMode changelogMode) {
- final CatalogTable unresolvedTable = new InlineCatalogTable(schema);
- final ResolvedCatalogTable catalogTable = new
ResolvedCatalogTable(unresolvedTable, schema);
final DynamicTableSource tableSource =
new ExternalDynamicSource<>(
- identifier, dataStream, physicalDataType,
isTopLevelRecord, changelogMode);
+ dataStream, physicalDataType, isTopLevelRecord,
changelogMode);
final FlinkStatistic statistic =
FlinkStatistic.builder()
// this is a temporary solution, FLINK-15123 will
resolve this
Review comment:
WDYM? I see this combination of the FlinkStatistic builder usage only
once
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
