Myasuka commented on a change in pull request #18391:
URL: https://github.com/apache/flink/pull/18391#discussion_r787671334
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/state/changelog/ChangelogStateBackendHandle.java
##########
@@ -66,16 +71,36 @@ public ChangelogStateBackendHandleImpl(
@Override
public void registerSharedStates(SharedStateRegistry stateRegistry,
long checkpointID) {
+ for (KeyedStateHandle keyedStateHandle : materialized) {
+ registerState(stateRegistry, checkpointID, MATERIALIZED_FLAG,
keyedStateHandle);
+ }
+ for (ChangelogStateHandle stateHandle : nonMaterialized) {
+ registerState(stateRegistry, checkpointID,
NON_MATERIALIZED_FLAG, stateHandle);
+ }
stateRegistry.registerAll(materialized, checkpointID);
stateRegistry.registerAll(nonMaterialized, checkpointID);
}
+ private void registerState(
+ SharedStateRegistry stateRegistry,
+ long checkpointID,
+ String prefix,
+ KeyedStateHandle keyedStateHandle) {
+ stateRegistry.registerReference(
+ new SharedStateRegistryKey(
+ prefix,
+ // here use hash code as registry key identifier.
+ new
StateHandleID(String.valueOf(keyedStateHandle.hashCode()))),
+ new StreamStateHandleWrapper(keyedStateHandle),
+ checkpointID);
Review comment:
| won't it solve the problem if we register all files in
IncrementalRemoteKeyedStateHandle with SharedStateRegistry (including metadata
etc.)?
I think changelog keyed state backend should be designed to wrap any keyed
state backend, we should consider the reference counting problem in changelog
state backend instead of modify the state handle returned in the wrapped state
backend. That's why I insist to change on changelog state-backend side.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
