Myasuka commented on a change in pull request #18382:
URL: https://github.com/apache/flink/pull/18382#discussion_r787869565
##########
File path:
flink-state-backends/flink-statebackend-changelog/src/main/java/org/apache/flink/state/changelog/ChangelogKeyedStateBackend.java
##########
@@ -453,7 +465,10 @@ public void notifyCheckpointAborted(long checkpointId)
throws Exception {
// This might change if the log ownership changes (the method
won't likely be needed).
stateChangelogWriter.reset(lastUploadedFrom, lastUploadedTo);
}
- keyedStateBackend.notifyCheckpointAborted(checkpointId);
+ Long materializationID =
materializationIdByCheckpointId.remove(checkpointId);
+ if (materializationID != null) {
Review comment:
Maybe removing the abort call directly is not good. We should better
call this finally at appropriate moment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
