GitHub user zentol opened a pull request:

    https://github.com/apache/flink/pull/2310

    [FLINK-4277] Fix TaskManagerConfigurationTest#testDefaultFsParameterLoading

    This PR fixes the 
`TaskManagerConfigurationTest#testDefaultFsParameterLoading` by creating a 
proper `flink-conf.yaml` file and passing the correct `--configDir` parameter.
    
    Previously, the generated yaml had a random name (`<random UUID>.yaml`) 
even though it should be called `flink-conf.yaml`. In addition, the 
`--configDir` parameter was set to the file name, and not directory it resides 
in.
    
    I don't know why this test did not fail earlier; maybe @mxm has an idea as 
he recently did some work on the `GlobalConfiguration`.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zentol/flink 4277_tm_configuration_test

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2310.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2310
    
----
commit fecd900b1030d0850ff8698ce85ee720c8cae613
Author: zentol <ches...@apache.org>
Date:   2016-07-29T10:15:54Z

    [FLINK-4277] Fix TaskManagerConfigurationTest#testDefaultFsParameterLoading

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to