[ https://issues.apache.org/jira/browse/FLINK-3674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15399459#comment-15399459 ]
ASF GitHub Bot commented on FLINK-3674: --------------------------------------- Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2301 I would suggest to close this PR and start with a proper design discussion. The approach taken here has a bunch of decisions/implications that I am not sure about, like - Mixing UDFs with "onWatermark" functionality with timers - Mixing windowed and not windowed code In a clean design, this feature should not touch any window operator code. Sorry for that, but that is why we encourage people to share designs before going full on implementing - at least for more complex additions like this one. > Add an interface for EventTime aware User Function > -------------------------------------------------- > > Key: FLINK-3674 > URL: https://issues.apache.org/jira/browse/FLINK-3674 > Project: Flink > Issue Type: New Feature > Components: Streaming > Affects Versions: 1.0.0 > Reporter: Stephan Ewen > Assignee: ramkrishna.s.vasudevan > > I suggest to add an interface that UDFs can implement, which will let them be > notified upon watermark updates. > Example usage: > {code} > public interface EventTimeFunction { > void onWatermark(Watermark watermark); > } > public class MyMapper implements MapFunction<String, String>, > EventTimeFunction { > private long currentEventTime = Long.MIN_VALUE; > public String map(String value) { > return value + " @ " + currentEventTime; > } > public void onWatermark(Watermark watermark) { > currentEventTime = watermark.getTimestamp(); > } > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)