fapaul opened a new pull request #18428:
URL: https://github.com/apache/flink/pull/18428


   <!--
   *Thank you very much for contributing to Apache Flink - we are happy that 
you want to help us improve Flink. To help the community review your 
contribution in the best possible way, please go through the checklist below, 
which will get the contribution into a shape in which it can be best reviewed.*
   
   *Please understand that we do not do this to make contributions to Flink a 
hassle. In order to uphold a high standard of quality for code contributions, 
while at the same time managing a large number of contributions, we need 
contributors to prepare the contributions well, and give reviewers enough 
contextual information for the review. Please also understand that 
contributions that do not follow this guide will take longer to review and thus 
typically be picked up with lower priority by the community.*
   
   ## Contribution Checklist
   
     - Make sure that the pull request corresponds to a [JIRA 
issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are 
made for typos in JavaDoc or documentation files, which need no JIRA issue.
     
     - Name the pull request in the form "[FLINK-XXXX] [component] Title of the 
pull request", where *FLINK-XXXX* should be replaced by the actual issue 
number. Skip *component* if you are unsure about which is the best component.
     Typo fixes that have no associated JIRA issue should be named following 
this pattern: `[hotfix] [docs] Fix typo in event time introduction` or 
`[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
   
     - Fill out the template below to describe the changes contributed by the 
pull request. That will give reviewers the context they need to do the review.
     
     - Make sure that the change passes the automated tests, i.e., `mvn clean 
verify` passes. You can set up Azure Pipelines CI to do that following [this 
guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
   
     - Each pull request should address only one issue, not mix up code from 
multiple issues.
     
     - Each commit in the pull request has a meaningful commit message 
(including the JIRA id)
   
     - Once all items of the checklist are addressed, remove the above text and 
this checklist, leaving only the filled out template below.
   
   
   **(The sections below can be removed for hotfixes of typos)**
   -->
   
   ## What is the purpose of the change
   
   This PR allows executing Sink V2 and migrates the internal operator 
representation of Sink V1 to also use the Sink V2 operators. So basically every 
Sink V1 now runs internally on the Sink V2 infrastructure. Only the 
GlobalCommitter is currently still missing but it is tracked as a followup in 
https://issues.apache.org/jira/browse/FLINK-25726.
   
   ## Brief change log
   
   - d45e3a669eece2fc287d454ed4d69a5a34c9dff9 This adds the internal structure 
send and book keep the Committable Messages it ensures that the operators 
working with CommittableMessages can ensure exactly-once processing
   - 029d72ebef1e5df84313ea9c23e86ee0ccaecda7 small change to expose the held 
transformations of the stream environment. It is mainly used later by the 
SinkTransformationTranslator to ingest newly added transformations to the 
StreamGraphGenerator
   - 90556071ebceb2a01768bae0db671d2a808f8e23 Batch/Blocking exchanges are now 
changed by the framework accordingly in Streaming Mode. They only have an 
effect in Batch Mode.
   - 5ba4487b7ade1c3066ae695183d2723427aa8d32 Introduce interface to forward 
information about the current execution mode to operator factories
   - fa0eaa1541ce6d05fe8460c060c45cb0f6bb196d Adds a simulation adapter to 
convert Sink V1 to Sink V2.
   - f799eeea34b4d3c5691cc4b77f5be103ef1c065c Implements the operator logic and 
adapts the SinkTransformationTranslation. Sorry for that commit it is very huge.
   
   ## Verifying this change
   
   Added multiple new tests for the new operators and for the adapter 
simulation. In general, all Sink IT cases also verify that the Sink V2 works.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (**yes** / no)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (**yes** / no 
/ don't know)
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't 
know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (**yes** / no)
     - If yes, how is the feature documented? (not applicable / docs / 
**JavaDocs** / not documented)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to