JingGe commented on a change in pull request #18397: URL: https://github.com/apache/flink/pull/18397#discussion_r790939938
########## File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/source/reader/deserializer/KafkaValueOnlyDeserializerWrapper.java ########## @@ -36,10 +36,15 @@ /** A package private class to wrap {@link Deserializer}. */ class KafkaValueOnlyDeserializerWrapper<T> implements KafkaRecordDeserializationSchema<T> { + private static final long serialVersionUID = 5409547407386004054L; + private static final Logger LOG = LoggerFactory.getLogger(KafkaValueOnlyDeserializerWrapper.class); + private final Class<? extends Deserializer<T>> deserializerClass; + // always be false since this Deserializer is only used for value. Review comment: Code style consistency means in this case that developers, when they come from `KafkaSerializerWrapper` will check the `isKey` at first to see if `deserializer.configure(...)` has been used in `KafkaValueOnlyDeserializerWrapper`. It is much easier to check it via instance variable than digging into the code. If you would try to read both classes back and forth, you would get the feeling. It is not a big deal. I will change it back. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org