syhily commented on a change in pull request #18388:
URL: https://github.com/apache/flink/pull/18388#discussion_r791185396



##########
File path: 
tools/ci/java-ci-tools/src/main/java/org/apache/flink/tools/ci/licensecheck/JarFileChecker.java
##########
@@ -210,6 +210,11 @@ private static int findNonBinaryFilesContainingText(
                     // dual-licensed under GPL 2 and EPL 2.0
                     // contained in sql-avro-confluent-registry
                     .filter(path -> !pathStartsWith(path, 
"/org/glassfish/jersey/internal"))
+                    // contained in sql-connector-pulsar
+                    .filter(
+                            path ->
+                                    !pathStartsWith(
+                                            path, 
"/org/apache/pulsar/shade/org/glassfish/jersey/"))

Review comment:
       Pulsar client shades a lot of jars, such as the `avro`. Can we just 
change this check filter to `/org/apache/pulsar/shade`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to