galenwarren opened a new pull request #18489: URL: https://github.com/apache/flink/pull/18489
## What is the purpose of the change For the GCS FileSystem plugin, use the same authentication options for the RecoverableWriter portion as is done for the normal FileSystem portion. This means that it will use GOOGLE_APPLICATION_CREDENTIALS, if it exists, but will also use the `google.cloud.auth.service.account.json.keyfile` property from Hadoop config. To have both portions of the plugin use the same rules, each of them will only consider using service credentials if the Hadoop property `google.cloud.auth.service.account.enable` is `true` or unspecified (i.e. the default value is `true`). ## Brief change log - Update `GSFileSystemFactory` to read Hadoop config from the location specified in `CoreOptions.FLINK_HADOOP_CONF_DIR` or in the `HADOOP_CONF_DIR` environment variable and to combine it with Hadoop config values from the Flink config - Update `GSFileSystem` to look for credentials in either `GOOGLE_APPLICATION_CREDENTIALS` or `google.cloud.auth.service.account.json.keyfile`, if `google.cloud.auth.service.account.enable` is not false, when constructing the `Storage` instance for the `RecoverableWriter` - ## Verifying this change Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing This change is a trivial rework / code cleanup without any test coverage. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (yes / no) No - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / no) No - The serializers: (yes / no / don't know) No - The runtime per-record code paths (performance sensitive): (yes / no / don't know) No - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know) No - The S3 file system connector: (yes / no / don't know) No ## Documentation - Does this pull request introduce a new feature? (yes / no) Yes - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented) Will be documented via https://github.com/apache/flink/pull/18430 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
