lindong28 commented on a change in pull request #18397:
URL: https://github.com/apache/flink/pull/18397#discussion_r791270225
##########
File path:
flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/sink/KafkaRecordSerializationSchemaBuilderTest.java
##########
@@ -160,6 +165,37 @@ public void testSerializeRecordWithKey() {
assertArrayEquals(record.value(), serializationSchema.serialize("a"));
}
+ @Test
+ public void testNoConfigurableKafkaKeySerializer() throws Exception {
+ final Map<String, String> config = ImmutableMap.of("simpleKey",
"simpleValue");
+ final KafkaRecordSerializationSchema<String> schema =
+ KafkaRecordSerializationSchema.builder()
+ .setTopic(DEFAULT_TOPIC)
+ // use StringSerializer as dummy Serializer, since
ValueSerializer is
Review comment:
Hmm.. It looks like all Javadoc (e.g. method, API) starts with first
letter being capital. But many non-Javadoc comments (e.g. comments in the
function body) starts with first letter being lower case. You are right that
this seems inconsistent...
I didn't find a rule for this on
https://flink.apache.org/contributing/code-style-and-quality-common.html. I was
primarily following Javadoc code style which almost always starts with an
upper-case letter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
