galenwarren commented on pull request #18409: URL: https://github.com/apache/flink/pull/18409#issuecomment-1020770497
@xintongsong Thanks for making the serializer version change. I'm only seeing it in `GSCommitRecoverableSerializer`, were you also planning to change it in `GSResumeRecoverableSerializer`? If you wanted, I think you could also change this line in each of the serializers' `deserialize` methods: ``` Preconditions.checkArgument(version >= 0); ``` ... to restrict the version to `version >= 1` instead. New users of the code should only see version >= 1. People who used the pre-released code may see version 0, but they would have to modify the deserialization code anyway to handle the old format, so they could change the precondition at that point. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
