syhily commented on a change in pull request #17452:
URL: https://github.com/apache/flink/pull/17452#discussion_r791421347



##########
File path: flink-connectors/flink-connector-pulsar/pom.xml
##########
@@ -163,13 +202,22 @@ under the License.
                </dependency>
        </dependencies>
 
-       <!-- gRPC use version range which don't support by flink ci. -->
        <dependencyManagement>
                <dependencies>
+                       <!-- Pulsar use higher gRPC version. -->
                        <dependency>
                                <groupId>io.grpc</groupId>
                                <artifactId>grpc-bom</artifactId>
-                               <version>${grpc.version}</version>
+                               <version>${pulsar-grpc.version}</version>
+                               <type>pom</type>
+                               <scope>import</scope>
+                       </dependency>
+
+                       <!-- Pulsar use higher netty version. -->
+                       <dependency>
+                               <groupId>io.netty</groupId>
+                               <artifactId>netty-bom</artifactId>
+                               <version>${pulsar-netty.version}</version>

Review comment:
       I have checked the dependencies in `flink-connector-pulsar`, we only use 
netty in tests. There is no compiled dependency for netty.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to