Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2275#discussion_r73160331
--- Diff:
flink-streaming-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaShortRetentionTestBase.java
---
@@ -60,18 +64,33 @@
private static Properties standardProps;
private static ForkableFlinkMiniCluster flink;
+ @ClassRule
+ public static TemporaryFolder tempFolder = new TemporaryFolder();
+
+ protected static Properties secureProps = new Properties();
+
@BeforeClass
public static void prepare() throws IOException, ClassNotFoundException
{
LOG.info("-------------------------------------------------------------------------");
LOG.info(" Starting KafkaShortRetentionTestBase ");
LOG.info("-------------------------------------------------------------------------");
+ Configuration flinkConfig = new Configuration();
+
// dynamically load the implementation for the test
Class<?> clazz =
Class.forName("org.apache.flink.streaming.connectors.kafka.KafkaTestEnvironmentImpl");
kafkaServer = (KafkaTestEnvironment)
InstantiationUtil.instantiate(clazz);
LOG.info("Starting KafkaTestBase.prepare() for Kafka " +
kafkaServer.getVersion());
+ LOG.info("Runtype: {}", RunTypeHolder.get());
+ if(RunTypeHolder.get().equals(RunTypeHolder.RunType.SECURE)
+ && kafkaServer.isSecureRunSupported()) {
+ SecureTestEnvironment.prepare(tempFolder);
+
SecureTestEnvironment.getSecurityEnabledFlinkConfiguration(flinkConfig);
--- End diff --
The name of the method doesn't suggest that though.
`SecureTestEnvironment.writeSecurityConfiguration(flinkConfig);` would make
it more explicit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
