slinkydeveloper commented on a change in pull request #18427:
URL: https://github.com/apache/flink/pull/18427#discussion_r793682035
##########
File path:
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/serde/DynamicTableSourceSpecSerdeTest.java
##########
@@ -238,6 +231,135 @@ public void testDynamicTableSourceSpecSerde() throws
IOException {
put("p", "B");
}
}))));
- return Arrays.asList(spec1, spec2);
+ return Stream.of(spec1, spec2);
+ }
+
+ @ParameterizedTest
+ @MethodSource("testDynamicTableSinkSpecSerde")
+ public void testDynamicTableSourceSpecSerde(DynamicTableSourceSpec spec)
throws IOException {
+ TableEnvironmentImpl tableEnv =
+ (TableEnvironmentImpl)
TableEnvironment.create(inStreamingMode());
+
+ CatalogManager catalogManager = tableEnv.getCatalogManager();
Review comment:
I tried to unify a bit some mocking, but there are some small
differences between the two. Abstracting those will just make the test
unreadable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
