reta opened a new pull request #18541: URL: https://github.com/apache/flink/pull/18541
Signed-off-by: Andriy Redko <andriy.re...@aiven.io> <!-- *Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.* *Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.* ## Contribution Checklist - Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue. - Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component. Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`. - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review. - Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository). - Each pull request should address only one issue, not mix up code from multiple issues. - Each commit in the pull request has a meaningful commit message (including the JIRA id) - Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below. **(The sections below can be removed for hotfixes of typos)** --> ## What is the purpose of the change The goal of this change is to provide dedicated Opensearch connectors. ## Brief change log The implementation is largely based on the existing Elasticsearch 7 connector with a few notable changes (besides the dependencies and APIs): - any mentions and uses of mapping types have been removed: it is deprecated feature, scheduled for removal (the indices with mapping types cannot be created or migrated to Opensearch 1.x and beyond) - any mentions and uses have been removed: it is deprecated feature, scheduled for removal (only `HighLevelRestClient` is used) - the default distributions of Opensearch come with HTTPS turned on, using self-signed certificates: to simplify the integration a new option `allow-insecure` has been added to suppress certificates validation for development and testing purposes - old streaming APIs are also supported to facilitate the migration of existing applications from Elasticsearch 7/6 to Opensearch (the classes will change but the familiar model will stay) The new connector name is `opensearch` and it follows the existing conventions: ``` CREATE TABLE users ( ... ) WITH ( 'connector' = 'opensearch', 'hosts' = 'https://localhost:9200', 'index' = 'users', 'allow-insecure' = 'true', 'username' = 'admin', 'password' = 'admin'); ``` ## Verifying this change This change added comprehensive tests and can be verified as follows (largely ported the existing unit and integration tests for Elasticsearch 7): - Added unit tests - Added integration tests for end-to-end - Manually verified the connector by running a node clusters ## Does this pull request potentially affect one of the following parts: - Dependencies: yes (the latest Opensearch 1.2.4 APIs as of this moment) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: yes - The serializers: no - The runtime per-record code paths (performance sensitive): no - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no - The S3 file system connector: no ## Documentation - Does this pull request introduce a new feature? yes - If yes, how is the feature documented? (docs - in progress, JavaDocs) Huge thanks @snuyanzin for help. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org