wangyang0918 commented on a change in pull request #18461: URL: https://github.com/apache/flink/pull/18461#discussion_r794258873
########## File path: flink-kubernetes/src/test/java/org/apache/flink/kubernetes/kubeclient/decorators/ExternalServiceDecoratorTest.java ########## @@ -118,5 +119,17 @@ public void testSetServiceExposedType() throws IOException { assertEquals( KubernetesConfigOptions.ServiceExposedType.ClusterIP.name(), ((Service) servicesWithClusterIP.get(0)).getSpec().getType()); + Review comment: Have such assert into a separate test looks better. And let's try to use the `org.hamcrest.MatcherAssert.assertThat` in the new introduced test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org