nlu90 commented on a change in pull request #17452: URL: https://github.com/apache/flink/pull/17452#discussion_r794722855
########## File path: flink-connectors/flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/common/config/PulsarConfigBuilder.java ########## @@ -0,0 +1,132 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.connector.pulsar.common.config; + +import org.apache.flink.annotation.Internal; +import org.apache.flink.configuration.ConfigOption; +import org.apache.flink.configuration.Configuration; +import org.apache.flink.configuration.UnmodifiableConfiguration; + +import java.util.ArrayList; +import java.util.List; +import java.util.Map; +import java.util.Objects; +import java.util.Properties; + +import static org.apache.flink.util.Preconditions.checkArgument; +import static org.apache.flink.util.Preconditions.checkNotNull; + +/** + * A builder for building the unmodifiable {@link Configuration} instance. Providing the common + * validate logic for source & sink. + */ +@Internal +public final class PulsarConfigBuilder { + + private final Configuration configuration = new Configuration(); + + /** Validate if the config has a existed option. */ + public <T> boolean contains(ConfigOption<T> option) { + return configuration.contains(option); + } + + /** + * Get a option related config value. We would return default config value which define in Review comment: nit: `which is defined` ########## File path: flink-connectors/flink-connector-pulsar/pom.xml ########## @@ -36,12 +36,14 @@ under the License. <packaging>jar</packaging> <properties> - <pulsar.version>2.8.0</pulsar.version> + <pulsar.version>2.9.1</pulsar.version> <!-- Test Libraries --> <protobuf-maven-plugin.version>0.6.1</protobuf-maven-plugin.version> - <commons-lang3.version>3.11</commons-lang3.version> - <grpc.version>1.33.0</grpc.version> + <pulsar-commons-lang3.version>3.11</pulsar-commons-lang3.version> + <pulsar-zookeeper.version>3.6.3</pulsar-zookeeper.version> Review comment: Just a heads up, Pulsar is trying to remove the hard binding of ZK. Later release should allow standalone pulsar running without ZK. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org