dawidwys commented on a change in pull request #18539: URL: https://github.com/apache/flink/pull/18539#discussion_r798699282
########## File path: flink-tests/src/test/java/org/apache/flink/test/checkpointing/SavepointFormatITCase.java ########## @@ -111,14 +111,35 @@ keyedState -> assertThat( keyedState, - instanceOf(KeyGroupsStateHandle.class)))); + instanceOf(KeyGroupsStateHandle.class))), + Arguments.of( + SavepointFormatType.CANONICAL, + ROCKSDB_INCREMENTAL_SNAPSHOTS, + (Consumer<KeyedStateHandle>) + keyedState -> + assertThat( + keyedState, + instanceOf(SavepointKeyedStateHandle.class))), + Arguments.of( + SavepointFormatType.NATIVE, + ROCKSDB_INCREMENTAL_SNAPSHOTS, + (Consumer<KeyedStateHandle>) + keyedState -> + assertThat( + keyedState, + instanceOf( + IncrementalRemoteKeyedStateHandle.class)))); Review comment: It is enough to verify the format of the savepoint. We verify savepoints are working if we restore from the savepoint without exceptions (after relocating it). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org