fapaul commented on a change in pull request #18615:
URL: https://github.com/apache/flink/pull/18615#discussion_r799473504
##########
File path:
flink-core/src/main/java/org/apache/flink/api/connector/sink/GlobalCommitter.java
##########
@@ -32,8 +32,11 @@
*
* @param <CommT> The type of information needed to commit data staged by the
sink
* @param <GlobalCommT> The type of the aggregated committable
+ * @deprecated Please use {@code WithPostCommitTopology} with {@code
+ * StandardSinkTopologies#addGlobalCommitter}.
Review comment:
I do not think we need a new interface for the global committer because
so far it is only used rarely and mainly as a committer running with
parallelism 1.
Theoretically, users can also use the global committer with
`WithPreCommittingTopology`.
In the long run, I'd expect that more people start using the
`WithPrecommitTopology` directly and less using the global committer. We just
have to introduce an alternative to the existing `GlobalCommitter` interface
therefore the helper method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
