twalthr commented on a change in pull request #18582: URL: https://github.com/apache/flink/pull/18582#discussion_r800501680
########## File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/casting/NumericToTimestampCastRule.java ########## @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.planner.functions.casting; + +import org.apache.flink.table.api.ValidationException; +import org.apache.flink.table.data.TimestampData; +import org.apache.flink.table.types.logical.LogicalType; +import org.apache.flink.table.types.logical.LogicalTypeFamily; +import org.apache.flink.table.types.logical.LogicalTypeRoot; + +/** + * {@link LogicalTypeFamily#NUMERIC} to {@link LogicalTypeRoot#TIMESTAMP_WITHOUT_TIME_ZONE}/{@link + * LogicalTypeRoot#TIMESTAMP_WITH_LOCAL_TIME_ZONE} cast rule. Disable cast conversion between + * Numeric type and Timestamp type and suggest to use {@code TO_TIMESTAMP()}/{@code + * TO_TIMESTAMP_LTZ()} instead. + */ +class NumericToTimestampCastRule + extends AbstractExpressionCodeGeneratorCastRule<Number, TimestampData> { + + static final NumericToTimestampCastRule INSTANCE = new NumericToTimestampCastRule(); + + private NumericToTimestampCastRule() { + super( + CastRulePredicate.builder() + .input(LogicalTypeFamily.NUMERIC) + .target(LogicalTypeRoot.TIMESTAMP_WITHOUT_TIME_ZONE) + .target(LogicalTypeRoot.TIMESTAMP_WITH_LOCAL_TIME_ZONE) + .build()); + } + + @Override + public String generateExpression( + CodeGeneratorCastRule.Context context, + String inputTerm, + LogicalType inputLogicalType, + LogicalType targetLogicalType) { + if (targetLogicalType.is(LogicalTypeRoot.TIMESTAMP_WITHOUT_TIME_ZONE)) { + throw new ValidationException( + "The cast conversion from NUMERIC type to TIMESTAMP type" + + " is not allowed, it's recommended to use TO_TIMESTAMP(FROM_UNIXTIME(numeric_col))" + + " instead, note the numeric is in seconds."); + } else if (targetLogicalType.is(LogicalTypeRoot.TIMESTAMP_WITH_LOCAL_TIME_ZONE)) { + throw new ValidationException( + "The cast conversion from NUMERIC type" Review comment: `The cast from....allowed. It's recommended` ########## File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/casting/TimestampToNumericCastRule.java ########## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.planner.functions.casting; + +import org.apache.flink.table.api.ValidationException; +import org.apache.flink.table.data.TimestampData; +import org.apache.flink.table.types.logical.LogicalType; +import org.apache.flink.table.types.logical.LogicalTypeFamily; +import org.apache.flink.table.types.logical.LogicalTypeRoot; + +/** + * {@link LogicalTypeRoot#TIMESTAMP_WITHOUT_TIME_ZONE}/{@link + * LogicalTypeRoot#TIMESTAMP_WITH_LOCAL_TIME_ZONE} to {@link LogicalTypeFamily#NUMERIC} cast rule. + * Disable cast conversion between Timestamp type and Numeric type and suggest to use {@code + * UNIX_TIMESTAMP()} instead (for {@link LogicalTypeRoot#TIMESTAMP_WITHOUT_TIME_ZONE}. + */ +class TimestampToNumericCastRule + extends AbstractExpressionCodeGeneratorCastRule<TimestampData, Number> { + + static final TimestampToNumericCastRule INSTANCE = new TimestampToNumericCastRule(); + + private TimestampToNumericCastRule() { + super( + CastRulePredicate.builder() + .input(LogicalTypeRoot.TIMESTAMP_WITHOUT_TIME_ZONE) + .input(LogicalTypeRoot.TIMESTAMP_WITH_LOCAL_TIME_ZONE) + .target(LogicalTypeFamily.NUMERIC) + .build()); + } + + @Override + public String generateExpression( + CodeGeneratorCastRule.Context context, + String inputTerm, + LogicalType inputLogicalType, + LogicalType targetLogicalType) { + if (inputLogicalType.is(LogicalTypeRoot.TIMESTAMP_WITHOUT_TIME_ZONE)) { + throw new ValidationException( + "The cast conversion from TIMESTAMP type to NUMERIC type" + + " is not allowed, it's recommended to use" + + " UNIX_TIMESTAMP(CAST(timestamp_col AS STRING)) instead."); + } else if (inputLogicalType.is(LogicalTypeRoot.TIMESTAMP_WITH_LOCAL_TIME_ZONE)) { + throw new ValidationException( + "The cast conversion from" Review comment: `The cast from....` ########## File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/casting/TimestampToNumericCastRule.java ########## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.planner.functions.casting; + +import org.apache.flink.table.api.ValidationException; +import org.apache.flink.table.data.TimestampData; +import org.apache.flink.table.types.logical.LogicalType; +import org.apache.flink.table.types.logical.LogicalTypeFamily; +import org.apache.flink.table.types.logical.LogicalTypeRoot; + +/** + * {@link LogicalTypeRoot#TIMESTAMP_WITHOUT_TIME_ZONE}/{@link + * LogicalTypeRoot#TIMESTAMP_WITH_LOCAL_TIME_ZONE} to {@link LogicalTypeFamily#NUMERIC} cast rule. + * Disable cast conversion between Timestamp type and Numeric type and suggest to use {@code + * UNIX_TIMESTAMP()} instead (for {@link LogicalTypeRoot#TIMESTAMP_WITHOUT_TIME_ZONE}. + */ +class TimestampToNumericCastRule + extends AbstractExpressionCodeGeneratorCastRule<TimestampData, Number> { + + static final TimestampToNumericCastRule INSTANCE = new TimestampToNumericCastRule(); + + private TimestampToNumericCastRule() { + super( + CastRulePredicate.builder() + .input(LogicalTypeRoot.TIMESTAMP_WITHOUT_TIME_ZONE) + .input(LogicalTypeRoot.TIMESTAMP_WITH_LOCAL_TIME_ZONE) + .target(LogicalTypeFamily.NUMERIC) + .build()); + } + + @Override + public String generateExpression( + CodeGeneratorCastRule.Context context, + String inputTerm, + LogicalType inputLogicalType, + LogicalType targetLogicalType) { + if (inputLogicalType.is(LogicalTypeRoot.TIMESTAMP_WITHOUT_TIME_ZONE)) { + throw new ValidationException( + "The cast conversion from TIMESTAMP type to NUMERIC type" Review comment: `The cast from....allowed. It's recommended` ########## File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/casting/TimestampToTimestampCastRule.java ########## @@ -0,0 +1,98 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.planner.functions.casting; + +import org.apache.flink.table.data.TimestampData; +import org.apache.flink.table.planner.codegen.calls.BuiltInMethods; +import org.apache.flink.table.types.logical.LogicalType; +import org.apache.flink.table.types.logical.LogicalTypeRoot; +import org.apache.flink.table.types.logical.TimestampKind; +import org.apache.flink.table.types.logical.TimestampType; +import org.apache.flink.table.types.logical.utils.LogicalTypeChecks; + +import static org.apache.flink.table.planner.functions.casting.CastRuleUtils.staticCall; + +/** + * {@link LogicalTypeRoot#TIMESTAMP_WITHOUT_TIME_ZONE}/{@link + * LogicalTypeRoot#TIMESTAMP_WITH_LOCAL_TIME_ZONE} to {@link + * LogicalTypeRoot#TIMESTAMP_WITHOUT_TIME_ZONE}/{@link LogicalTypeRoot#TIMESTAMP_WITHOUT_TIME_ZONE} + * cast rule. Check and adjust if there is the precision changes. + */ +class TimestampToTimestampCastRule + extends AbstractExpressionCodeGeneratorCastRule<TimestampData, TimestampData> { + + static final TimestampToTimestampCastRule INSTANCE = new TimestampToTimestampCastRule(); + + private TimestampToTimestampCastRule() { + super( + CastRulePredicate.builder() + .input(LogicalTypeRoot.TIMESTAMP_WITHOUT_TIME_ZONE) + .input(LogicalTypeRoot.TIMESTAMP_WITH_LOCAL_TIME_ZONE) + .target(LogicalTypeRoot.TIMESTAMP_WITHOUT_TIME_ZONE) + .target(LogicalTypeRoot.TIMESTAMP_WITH_LOCAL_TIME_ZONE) + .build()); + } + + @Override + public String generateExpression( + CodeGeneratorCastRule.Context context, + String inputTerm, + LogicalType inputLogicalType, + LogicalType targetLogicalType) { + final int inputPrecision = LogicalTypeChecks.getPrecision(inputLogicalType); + int targetPrecision = LogicalTypeChecks.getPrecision(targetLogicalType); + + if (inputLogicalType.is(LogicalTypeRoot.TIMESTAMP_WITHOUT_TIME_ZONE) + && targetLogicalType.is(LogicalTypeRoot.TIMESTAMP_WITHOUT_TIME_ZONE)) { + final TimestampKind inputTimestampKind = ((TimestampType) inputLogicalType).getKind(); + final TimestampKind targetTimestampKind = ((TimestampType) targetLogicalType).getKind(); + if (inputTimestampKind == TimestampKind.ROWTIME + || inputTimestampKind == TimestampKind.PROCTIME + || targetTimestampKind == TimestampKind.ROWTIME + || targetTimestampKind == TimestampKind.PROCTIME) { + targetPrecision = 3; Review comment: why is it necessary to change the target precision in this case? What happens if we don't apply this? ########## File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/casting/NumericToTimestampCastRule.java ########## @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.planner.functions.casting; + +import org.apache.flink.table.api.ValidationException; +import org.apache.flink.table.data.TimestampData; +import org.apache.flink.table.types.logical.LogicalType; +import org.apache.flink.table.types.logical.LogicalTypeFamily; +import org.apache.flink.table.types.logical.LogicalTypeRoot; + +/** + * {@link LogicalTypeFamily#NUMERIC} to {@link LogicalTypeRoot#TIMESTAMP_WITHOUT_TIME_ZONE}/{@link + * LogicalTypeRoot#TIMESTAMP_WITH_LOCAL_TIME_ZONE} cast rule. Disable cast conversion between + * Numeric type and Timestamp type and suggest to use {@code TO_TIMESTAMP()}/{@code + * TO_TIMESTAMP_LTZ()} instead. + */ +class NumericToTimestampCastRule + extends AbstractExpressionCodeGeneratorCastRule<Number, TimestampData> { + + static final NumericToTimestampCastRule INSTANCE = new NumericToTimestampCastRule(); + + private NumericToTimestampCastRule() { + super( + CastRulePredicate.builder() + .input(LogicalTypeFamily.NUMERIC) + .target(LogicalTypeRoot.TIMESTAMP_WITHOUT_TIME_ZONE) + .target(LogicalTypeRoot.TIMESTAMP_WITH_LOCAL_TIME_ZONE) + .build()); + } + + @Override + public String generateExpression( + CodeGeneratorCastRule.Context context, + String inputTerm, + LogicalType inputLogicalType, + LogicalType targetLogicalType) { + if (targetLogicalType.is(LogicalTypeRoot.TIMESTAMP_WITHOUT_TIME_ZONE)) { + throw new ValidationException( + "The cast conversion from NUMERIC type to TIMESTAMP type" + + " is not allowed, it's recommended to use TO_TIMESTAMP(FROM_UNIXTIME(numeric_col))" Review comment: `The cast from....allowed. It's recommended` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
