pltbkd commented on a change in pull request #18642:
URL: https://github.com/apache/flink/pull/18642#discussion_r801253773
##########
File path:
flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/sink/committer/FileCommitter.java
##########
@@ -48,9 +47,10 @@ public FileCommitter(BucketWriter<?, ?> bucketWriter) {
}
@Override
- public List<FileSinkCommittable> commit(List<FileSinkCommittable>
committables)
- throws IOException {
- for (FileSinkCommittable committable : committables) {
+ public void commit(Collection<CommitRequest<FileSinkCommittable>> requests)
+ throws IOException, InterruptedException {
+ for (CommitRequest<FileSinkCommittable> request : requests) {
Review comment:
This is inherited from the interface. Maybe we can discuss whether to
allow throwing exceptions here or to make a agreement that all exceptions
while committing should be reported via the CommitRequest (unless the exception
is not bounded to a specific request)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
