pnowojski commented on a change in pull request #18665:
URL: https://github.com/apache/flink/pull/18665#discussion_r802638272
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/source/coordinator/SourceCoordinator.java
##########
@@ -101,16 +115,71 @@ Licensed to the Apache Software Foundation (ASF) under one
public SourceCoordinator(
Review comment:
we could, but do we like better a bit of code duplication with passing
`WATERMARK_ALIGNMENT_DISABLED` parameter (and making it "more public" api) or
having an extra constructor? I would lean slightly towards easier construction
in tests and less duplicated code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
