zentol commented on a change in pull request #18692:
URL: https://github.com/apache/flink/pull/18692#discussion_r803512948



##########
File path: flink-core/src/main/java/org/apache/flink/core/fs/FileSystem.java
##########
@@ -588,8 +588,10 @@ public static URI getDefaultFsUri() {
      *
      * @param f The path we want information from
      * @return a FileStatus object
-     * @throws FileNotFoundException when the path does not exist; IOException 
see specific
-     *     implementation
+     * @throws FileNotFoundException when the path does not exist. This also 
applies to cases where
+     *     the {@code FileSystem} implementation is based on an object store 
like S3 and the passed
+     *     {@code Path} refers to a directory (even if it was created through 
{@link #mkdirs(Path)};

Review comment:
       Looking at the S3 FileSystem implementation I'm not sure if this is 
generally correct. Directories _technically_ don't exist; when you do a mkdirs 
it creates an object that pretends to be a directory (in the plain hadoop s3 
filesystem).
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to