[ 
https://issues.apache.org/jira/browse/FLINK-25875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17490147#comment-17490147
 ] 

Chesnay Schepler commented on FLINK-25875:
------------------------------------------

What I'm looking for a is a specification of the StatsD protocol that says 
these characters are invalid. If the StatsD protocol says they are fine, then 
this is an issue with Graphite.
Note that StatsD itself pushed this responsibility into the backends: 
https://github.com/statsd/statsd/issues/110

> "StatsDReporter. FilterCharacters" for special processing of the characters 
> are comprehensive enough
> ----------------------------------------------------------------------------------------------------
>
>                 Key: FLINK-25875
>                 URL: https://issues.apache.org/jira/browse/FLINK-25875
>             Project: Flink
>          Issue Type: Improvement
>          Components: Runtime / Metrics
>    Affects Versions: 1.14.3
>            Reporter: 赵富午
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: image-2022-01-29-11-55-20-400.png
>
>
> I based on the 「org.Apache.Flink.Metrics.Statsd.StatsDReporter」 metrics 
> collection, query and display and use 「Graphite」, I found some flink metrics 
> cannot be queried to, after screening, I found the reason, These indicators 
> cannot be parsed because they contain space characters. I further track 
> source code, I found 「StatsDReporter.FilterCharacters」 function for the 
> processing of special characters is not qualified, only to replace ":" 
> character, for other special characters and didn't do a good replacement, 
> such as a space character.
> !image-2022-01-29-11-55-38-064.png!
> [https://nightlies.apache.org/flink/flink-docs-master/docs/ops/metrics/#garbagecollection]
> JVM "Garbagecollection" grouping, indicators have space characters, 
> indicators cannot be used because indicators cannot be correctly parsed and 
> stored in the database. 
>  



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to