pnowojski commented on a change in pull request #49: URL: https://github.com/apache/flink-benchmarks/pull/49#discussion_r803619263
########## File path: src/main/java/org/apache/flink/benchmark/BlockingPartitionRemoteChannelBenchmark.java ########## @@ -49,7 +49,15 @@ public static void main(String[] args) throws RunnerException { } @Benchmark - public void remoteFilePartition(BlockingPartitionEnvironmentContext context) throws Exception { + public void remoteFilePartition(RemoteFileEnvironmentContext context) throws Exception { + StreamGraph streamGraph = + StreamGraphUtils.buildGraphForBatchJob(context.env, RECORDS_PER_INVOCATION); + context.miniCluster.executeJobBlocking( + StreamingJobGraphGenerator.createJobGraph(streamGraph)); + } + + @Benchmark + public void remoteSortShufflePartition(RemoteSortShuffleEnvironmentContext context) throws Exception { Review comment: nit ditto: `remoteSortPartition`? ########## File path: src/main/java/org/apache/flink/benchmark/BlockingPartitionBenchmark.java ########## @@ -66,6 +66,16 @@ public void uncompressedMmapPartition(UncompressedMmapEnvironmentContext context executeBenchmark(context.env); } + @Benchmark + public void compressedSortShufflePartition(CompressedSortShuffleEnvironmentContext context) throws Exception { + executeBenchmark(context.env); + } + + @Benchmark + public void uncompressedSortShufflePartition(UncompressedSortShuffleEnvironmentContext context) throws Exception { + executeBenchmark(context.env); + } + Review comment: nit: rename to `compressedSortPartition` and `uncompressedSortPartition` to shorten the benchmark name in the web UI? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org