rkhachatryan commented on a change in pull request #18391:
URL: https://github.com/apache/flink/pull/18391#discussion_r803666621
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/state/changelog/ChangelogStateBackendHandle.java
##########
@@ -71,20 +76,30 @@ public ChangelogStateBackendHandleImpl(
this.persistedSizeOfThisCheckpoint = persistedSizeOfThisCheckpoint;
checkArgument(keyGroupRange.getNumberOfKeyGroups() > 0);
this.materializationID = materializationID;
+ this.stateHandleID = new
StateHandleID(UUID.randomUUID().toString());
Review comment:
Moving
[this](https://github.com/apache/flink/pull/18391#discussion_r803524862)
comment here:
> Creating a random ID here doesn't seem very straightforward to me, when
looking at the call sites.
> Especially, MetadataV2V3SerializerBase - why doesn't it store this ID? I
guess it's fine because currently it's only used inside this handle itself; but
if ID will be used for other purposes then it may become an issue.
> So I'd propose to have an explicit contructor argument (at least for
production code); and store this ID in the metadata.
> WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
