dmvk commented on a change in pull request #18553: URL: https://github.com/apache/flink/pull/18553#discussion_r803673665
########## File path: flink-connectors/flink-connector-aws-kinesis-firehose/src/test/java/org/apache/flink/connector/firehose/sink/KinesisFirehoseSinkITCase.java ########## @@ -78,42 +76,36 @@ @Before public void setup() throws Exception { System.setProperty(SdkSystemSetting.CBOR_ENABLED.property(), "false"); - httpClient = AWSServicesTestUtils.createHttpClient(mockFirehoseContainer.getEndpoint()); - s3AsyncClient = createS3Client(mockFirehoseContainer.getEndpoint(), httpClient); - firehoseAsyncClient = getFirehoseClient(mockFirehoseContainer.getEndpoint(), httpClient); - iamAsyncClient = createIamClient(mockFirehoseContainer.getEndpoint(), httpClient); + s3HttpClient = createHttpClient(mockFirehoseContainer.getEndpoint()); + firehoseHttpClient = createHttpClient(mockFirehoseContainer.getEndpoint()); + iamHttpClient = createHttpClient(mockFirehoseContainer.getEndpoint()); + s3AsyncClient = createS3Client(mockFirehoseContainer.getEndpoint(), s3HttpClient); + firehoseAsyncClient = + getFirehoseClient(mockFirehoseContainer.getEndpoint(), firehoseHttpClient); + iamAsyncClient = createIamClient(mockFirehoseContainer.getEndpoint(), iamHttpClient); + env = StreamExecutionEnvironment.getExecutionEnvironment(); Review comment: There is something sketchy going on with thread locals and XML parser service loading. This can signal some deeper issues, so we should make sure why exactly this is happening, even though we have a "workaround" that works for some reason. ``` Feb 10 10:57:30 Caused by: java.lang.IllegalStateException: Trying to access closed classloader. Please check if you store classloaders directly or indirectly in static fields. If the stacktrace suggests that the leak occurs in a third party library and cannot be fixed immediately, you can disable this check with the configuration 'classloader.check-leaked-classloader'. Feb 10 10:57:30 at org.apache.flink.runtime.execution.librarycache.FlinkUserCodeClassLoaders$SafetyNetWrapperClassLoader.ensureInner(FlinkUserCodeClassLoaders.java:164) Feb 10 10:57:30 at org.apache.flink.runtime.execution.librarycache.FlinkUserCodeClassLoaders$SafetyNetWrapperClassLoader.getResources(FlinkUserCodeClassLoaders.java:188) Feb 10 10:57:30 at java.util.ServiceLoader$LazyIterator.hasNextService(ServiceLoader.java:348) Feb 10 10:57:30 at java.util.ServiceLoader$LazyIterator.hasNext(ServiceLoader.java:393) Feb 10 10:57:30 at java.util.ServiceLoader$1.hasNext(ServiceLoader.java:474) Feb 10 10:57:30 at javax.xml.stream.FactoryFinder$1.run(FactoryFinder.java:352) Feb 10 10:57:30 at java.security.AccessController.doPrivileged(Native Method) Feb 10 10:57:30 at javax.xml.stream.FactoryFinder.findServiceProvider(FactoryFinder.java:341) Feb 10 10:57:30 at javax.xml.stream.FactoryFinder.find(FactoryFinder.java:313) Feb 10 10:57:30 at javax.xml.stream.FactoryFinder.find(FactoryFinder.java:227) Feb 10 10:57:30 at javax.xml.stream.XMLInputFactory.newInstance(XMLInputFactory.java:154) Feb 10 10:57:30 at software.amazon.awssdk.protocols.query.unmarshall.XmlDomParser.createXmlInputFactory(XmlDomParser.java:124) Feb 10 10:57:30 at java.lang.ThreadLocal$SuppliedThreadLocal.initialValue(ThreadLocal.java:284) Feb 10 10:57:30 at java.lang.ThreadLocal.setInitialValue(ThreadLocal.java:180) Feb 10 10:57:30 at java.lang.ThreadLocal.get(ThreadLocal.java:170) Feb 10 10:57:30 at software.amazon.awssdk.protocols.query.unmarshall.XmlDomParser.parse(XmlDomParser.java:44) Feb 10 10:57:30 at software.amazon.awssdk.protocols.xml.internal.unmarshall.XmlResponseParserUtils.parse(XmlResponseParserUtils.java:56) Feb 10 10:57:30 at software.amazon.awssdk.protocols.xml.internal.unmarshall.AwsXmlPredicatedResponseHandler.parseResponse(AwsXmlPredicatedResponseHandler.java:114) Feb 10 10:57:30 at software.amazon.awssdk.protocols.xml.internal.unmarshall.AwsXmlPredicatedResponseHandler.handleResponse(AwsXmlPredicatedResponseHandler.java:95) Feb 10 10:57:30 at software.amazon.awssdk.protocols.xml.internal.unmarshall.AwsXmlPredicatedResponseHandler.handle(AwsXmlPredicatedResponseHandler.java:84) Feb 10 10:57:30 at software.amazon.awssdk.protocols.xml.internal.unmarshall.AwsXmlPredicatedResponseHandler.handle(AwsXmlPredicatedResponseHandler.java:42) Feb 10 10:57:30 at software.amazon.awssdk.core.internal.handler.BaseClientHandler.lambda$successTransformationResponseHandler$6(BaseClientHandler.java:232) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org