dannycranmer commented on a change in pull request #18603:
URL: https://github.com/apache/flink/pull/18603#discussion_r803835349



##########
File path: 
flink-connectors/flink-sql-connector-aws-kinesis-firehose/src/main/resources/META-INF/NOTICE
##########
@@ -0,0 +1,53 @@
+flink-sql-connector-aws-kinesis-data-firehose
+
+Copyright 2014-2021 The Apache Software Foundation
+
+This product includes software developed at
+The Apache Software Foundation (http://www.apache.org/).
+
+This project bundles the following dependencies under the Apache Software 
License 2.0. (http://www.apache.org/licenses/LICENSE-2.0.txt)
+
+- software.amazon.awssdk:kinesis:2.17.52
+- software.amazon.awssdk:firehose:2.17.52
+- software.amazon.awssdk:s3:2.17.52
+- software.amazon.awssdk:iam:2.17.52
+- software.amazon.awssdk:aws-cbor-protocol:2.17.52
+- software.amazon.awssdk:aws-json-protocol:2.17.52
+- software.amazon.awssdk:protocol-core:2.17.52
+- software.amazon.awssdk:profiles:2.17.52
+- software.amazon.awssdk:sdk-core:2.17.52
+- software.amazon.awssdk:auth:2.17.52
+- software.amazon.eventstream:eventstream:1.0.1
+- software.amazon.awssdk:http-client-spi:2.17.52
+- software.amazon.awssdk:regions:2.17.52
+- software.amazon.awssdk:annotations:2.17.52
+- software.amazon.awssdk:utils:2.17.52
+- software.amazon.awssdk:aws-core:2.17.52
+- software.amazon.awssdk:metrics-spi:2.17.52
+- software.amazon.awssdk:apache-client:2.17.52
+- software.amazon.awssdk:netty-nio-client:2.17.52
+- software.amazon.awssdk:sts:2.17.52
+- software.amazon.awssdk:aws-query-protocol:2.17.52
+- software.amazon.awssdk:json-utils:2.17.52
+- software.amazon.awssdk:third-party-jackson-core:2.17.52
+- software.amazon.awssdk:third-party-jackson-dataformat-cbor:2.17.52
+- io.netty:netty-codec-http:4.1.70.Final
+- io.netty:netty-codec-http2:4.1.70.Final
+- io.netty:netty-codec:4.1.70.Final
+- io.netty:netty-transport:4.1.70.Final
+- io.netty:netty-resolver:4.1.70.Final
+- io.netty:netty-common:4.1.70.Final
+- io.netty:netty-buffer:4.1.70.Final
+- io.netty:netty-handler:4.1.70.Final
+- io.netty:netty-transport-native-epoll:linux-x86_64:4.1.70.Final
+- io.netty:netty-transport-native-unix-common:4.1.70.Final
+- io.netty:netty-transport-classes-epoll:4.1.70.Final
+- com.typesafe.netty:netty-reactive-streams-http:2.0.5
+- com.typesafe.netty:netty-reactive-streams:2.0.5
+- org.apache.httpcomponents:httpclient:4.5.13
+- org.apache.httpcomponents:httpcore:4.4.14
+
+This project bundles the following dependencies under the Creative Commons 
Zero license (https://creativecommons.org/publicdomain/zero/1.0/).
+
+- org.reactivestreams:reactive-streams:1.0.3
+

Review comment:
       I believe all these ones need to be deleted:
   
   ```
   - software.amazon.awssdk:kinesis:2.17.52
   - software.amazon.awssdk:s3:2.17.52
   - software.amazon.awssdk:iam:2.17.52
   - software.amazon.awssdk:aws-cbor-protocol:2.17.52
   - software.amazon.eventstream:eventstream:1.0.1
   - software.amazon.awssdk:third-party-jackson-dataformat-cbor:2.17.52
    ```

##########
File path: 
flink-connectors/flink-sql-connector-aws-kinesis-firehose/src/main/resources/META-INF/NOTICE
##########
@@ -0,0 +1,53 @@
+flink-sql-connector-aws-kinesis-data-firehose
+
+Copyright 2014-2021 The Apache Software Foundation
+
+This product includes software developed at
+The Apache Software Foundation (http://www.apache.org/).
+
+This project bundles the following dependencies under the Apache Software 
License 2.0. (http://www.apache.org/licenses/LICENSE-2.0.txt)
+
+- software.amazon.awssdk:kinesis:2.17.52
+- software.amazon.awssdk:firehose:2.17.52
+- software.amazon.awssdk:s3:2.17.52
+- software.amazon.awssdk:iam:2.17.52
+- software.amazon.awssdk:aws-cbor-protocol:2.17.52
+- software.amazon.awssdk:aws-json-protocol:2.17.52
+- software.amazon.awssdk:protocol-core:2.17.52
+- software.amazon.awssdk:profiles:2.17.52
+- software.amazon.awssdk:sdk-core:2.17.52
+- software.amazon.awssdk:auth:2.17.52
+- software.amazon.eventstream:eventstream:1.0.1
+- software.amazon.awssdk:http-client-spi:2.17.52
+- software.amazon.awssdk:regions:2.17.52
+- software.amazon.awssdk:annotations:2.17.52
+- software.amazon.awssdk:utils:2.17.52
+- software.amazon.awssdk:aws-core:2.17.52
+- software.amazon.awssdk:metrics-spi:2.17.52
+- software.amazon.awssdk:apache-client:2.17.52
+- software.amazon.awssdk:netty-nio-client:2.17.52
+- software.amazon.awssdk:sts:2.17.52
+- software.amazon.awssdk:aws-query-protocol:2.17.52
+- software.amazon.awssdk:json-utils:2.17.52
+- software.amazon.awssdk:third-party-jackson-core:2.17.52
+- software.amazon.awssdk:third-party-jackson-dataformat-cbor:2.17.52
+- io.netty:netty-codec-http:4.1.70.Final
+- io.netty:netty-codec-http2:4.1.70.Final
+- io.netty:netty-codec:4.1.70.Final
+- io.netty:netty-transport:4.1.70.Final
+- io.netty:netty-resolver:4.1.70.Final
+- io.netty:netty-common:4.1.70.Final
+- io.netty:netty-buffer:4.1.70.Final
+- io.netty:netty-handler:4.1.70.Final
+- io.netty:netty-transport-native-epoll:linux-x86_64:4.1.70.Final
+- io.netty:netty-transport-native-unix-common:4.1.70.Final
+- io.netty:netty-transport-classes-epoll:4.1.70.Final
+- com.typesafe.netty:netty-reactive-streams-http:2.0.5
+- com.typesafe.netty:netty-reactive-streams:2.0.5
+- org.apache.httpcomponents:httpclient:4.5.13
+- org.apache.httpcomponents:httpcore:4.4.14
+
+This project bundles the following dependencies under the Creative Commons 
Zero license (https://creativecommons.org/publicdomain/zero/1.0/).
+
+- org.reactivestreams:reactive-streams:1.0.3
+

Review comment:
       Here is the full output:
   
   ```
   [INFO] Including 
org.apache.flink:flink-connector-aws-kinesis-firehose:jar:1.15-SNAPSHOT in the 
shaded jar.
   [INFO] Including org.apache.flink:flink-connector-base:jar:1.15-SNAPSHOT in 
the shaded jar.
   [INFO] Including org.apache.flink:flink-connector-aws-base:jar:1.15-SNAPSHOT 
in the shaded jar.
   [INFO] Including software.amazon.awssdk:sts:jar:2.17.52 in the shaded jar.
   [INFO] Including software.amazon.awssdk:aws-query-protocol:jar:2.17.52 in 
the shaded jar.
   [INFO] Including software.amazon.awssdk:sdk-core:jar:2.17.52 in the shaded 
jar.
   [INFO] Including software.amazon.awssdk:annotations:jar:2.17.52 in the 
shaded jar.
   [INFO] Including software.amazon.awssdk:http-client-spi:jar:2.17.52 in the 
shaded jar.
   [INFO] Including software.amazon.awssdk:metrics-spi:jar:2.17.52 in the 
shaded jar.
   [INFO] Including software.amazon.awssdk:utils:jar:2.17.52 in the shaded jar.
   [INFO] Including software.amazon.awssdk:profiles:jar:2.17.52 in the shaded 
jar.
   [INFO] Including org.reactivestreams:reactive-streams:jar:1.0.3 in the 
shaded jar.
   [INFO] Including software.amazon.awssdk:firehose:jar:2.17.52 in the shaded 
jar.
   [INFO] Including software.amazon.awssdk:aws-json-protocol:jar:2.17.52 in the 
shaded jar.
   [INFO] Including software.amazon.awssdk:third-party-jackson-core:jar:2.17.52 
in the shaded jar.
   [INFO] Including software.amazon.awssdk:json-utils:jar:2.17.52 in the shaded 
jar.
   [INFO] Including software.amazon.awssdk:protocol-core:jar:2.17.52 in the 
shaded jar.
   [INFO] Including software.amazon.awssdk:auth:jar:2.17.52 in the shaded jar.
   [INFO] Excluding software.amazon.eventstream:eventstream:jar:1.0.1 from the 
shaded jar.
   [INFO] Including software.amazon.awssdk:regions:jar:2.17.52 in the shaded 
jar.
   [INFO] Including software.amazon.awssdk:aws-core:jar:2.17.52 in the shaded 
jar.
   [INFO] Including software.amazon.awssdk:apache-client:jar:2.17.52 in the 
shaded jar.
   [INFO] Including org.apache.httpcomponents:httpclient:jar:4.5.13 in the 
shaded jar.
   [INFO] Excluding commons-logging:commons-logging:jar:1.1.3 from the shaded 
jar.
   [INFO] Excluding commons-codec:commons-codec:jar:1.15 from the shaded jar.
   [INFO] Including org.apache.httpcomponents:httpcore:jar:4.4.14 in the shaded 
jar.
   [INFO] Including software.amazon.awssdk:netty-nio-client:jar:2.17.52 in the 
shaded jar.
   [INFO] Including io.netty:netty-codec-http:jar:4.1.70.Final in the shaded 
jar.
   [INFO] Including io.netty:netty-codec-http2:jar:4.1.70.Final in the shaded 
jar.
   [INFO] Including io.netty:netty-codec:jar:4.1.70.Final in the shaded jar.
   [INFO] Including io.netty:netty-transport:jar:4.1.70.Final in the shaded jar.
   [INFO] Including io.netty:netty-resolver:jar:4.1.70.Final in the shaded jar.
   [INFO] Including io.netty:netty-common:jar:4.1.70.Final in the shaded jar.
   [INFO] Including io.netty:netty-buffer:jar:4.1.70.Final in the shaded jar.
   [INFO] Including io.netty:netty-handler:jar:4.1.70.Final in the shaded jar.
   [INFO] Including 
io.netty:netty-transport-native-epoll:jar:linux-x86_64:4.1.70.Final in the 
shaded jar.
   [INFO] Including 
io.netty:netty-transport-native-unix-common:jar:4.1.70.Final in the shaded jar.
   [INFO] Including io.netty:netty-transport-classes-epoll:jar:4.1.70.Final in 
the shaded jar.
   [INFO] Including com.typesafe.netty:netty-reactive-streams-http:jar:2.0.5 in 
the shaded jar.
   [INFO] Including com.typesafe.netty:netty-reactive-streams:jar:2.0.5 in the 
shaded jar.
   [INFO] Excluding org.apache.flink:flink-shaded-force-shading:jar:15.0 from 
the shaded jar.
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to