Github user iemejia commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2340#discussion_r74261518
  
    --- Diff: flink-contrib/docker-flink/Dockerfile ---
    @@ -22,25 +22,30 @@ FROM java:8-jre-alpine
     RUN apk add --no-cache bash snappy
     
     # Configure Flink version
    -ARG FLINK_VERSION=1.0.3
    +ARG FLINK_VERSION=1.1.0
     ARG HADOOP_VERSION=27
     ARG SCALA_VERSION=2.11
     
    +# Flink environment variables
    +ENV FLINK_HOME /opt/flink
    +ENV PATH $PATH:$FLINK_HOME/bin
    +
     # Install build dependencies and flink
     RUN set -x && \
    +  mkdir -p /opt && \
       apk --update add --virtual build-dependencies curl && \
    -  curl -s $(curl -s https://www.apache.org/dyn/closer.cgi\?as_json\=1 | \
    -  awk '/preferred/ {gsub(/"/,""); print 
$2}')flink/flink-${FLINK_VERSION}/flink-${FLINK_VERSION}-bin-hadoop${HADOOP_VERSION}-scala_${SCALA_VERSION}.tgz
 | \
    -  tar xvz -C /usr/local/ && \
    -  ln -s /usr/local/flink-$FLINK_VERSION /usr/local/flink && \
    -  sed -i -e "s/echo \$mypid >> \$pid/echo \$mypid >> \$pid \&\& wait/g" 
/usr/local/flink/bin/flink-daemon.sh && \
    +  curl -s 
https://archive.apache.org/dist/flink/flink-$FLINK_VERSION/flink-$FLINK_VERSION-bin-hadoop$HADOOP_VERSION-scala_$SCALA_VERSION.tgz
 | \
    --- End diff --
    
    Notice that I have another argument against the mirrors and it is the 
security issue, imagine that a malign mirror puts a wrong version of flink, I 
wonder what is the recomended approach to validate this case (of course notice 
that I asume that hacking apache would be harder).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to