slinkydeveloper commented on a change in pull request #18667: URL: https://github.com/apache/flink/pull/18667#discussion_r804494179
########## File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/connectors/TransformationSinkProvider.java ########## @@ -37,15 +40,24 @@ @Internal public interface TransformationSinkProvider extends DynamicTableSink.SinkRuntimeProvider { - /** Creates a transformation for transforming the input provided in the context. */ + /** + * Creates a transformation for transforming the input provided in the context. + * + * <p>This method MUST set an uid for each node of the transformation sink, when the job is + * unbounded, which can be generated with {@link Context#generateUid(String)}. + */ Transformation<?> createTransformation(Context context); /** Context for {@link #createTransformation(Context)}. */ - interface Context { + interface Context extends ProviderContext { Review comment: But then the solution is just to don't have static import for `Context`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org