vahmed-hamdy commented on a change in pull request #18669: URL: https://github.com/apache/flink/pull/18669#discussion_r804660040
########## File path: flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/writer/BufferedRequestState.java ########## @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.connector.base.sink.writer; + +import org.apache.flink.annotation.PublicEvolving; + +import java.io.Serializable; +import java.util.ArrayList; +import java.util.Collections; +import java.util.Deque; +import java.util.List; + +/** + * Class holding state of {@link AsyncSinkWriter} needed at taking a snapshot. The state captures + * the {@code bufferedRequestEntries} buffer for the writer at snapshot to resume the requests. This + * guarantees at least once semantic in sending requests where restoring from a snapshot where + * buffered requests were flushed to the sink will cause duplicate requests. + * + * @param <RequestEntryT> request type. + */ +@PublicEvolving +public class BufferedRequestState<RequestEntryT extends Serializable> implements Serializable { + private final List<RequestEntryWrapper<RequestEntryT>> bufferedRequestEntries; + private final long stateSize; + + public BufferedRequestState(Deque<RequestEntryWrapper<RequestEntryT>> bufferedRequestEntries) { + this.bufferedRequestEntries = new ArrayList<>(bufferedRequestEntries); + this.stateSize = calculateStateSize(); + } + + public BufferedRequestState(List<RequestEntryWrapper<RequestEntryT>> bufferedRequestEntries) { + this.bufferedRequestEntries = new ArrayList<>(bufferedRequestEntries); + this.stateSize = calculateStateSize(); + } Review comment: They were already, were split out to ensure an ordering data structure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
