[
https://issues.apache.org/jira/browse/FLINK-4362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15417385#comment-15417385
]
ASF GitHub Bot commented on FLINK-4362:
---------------------------------------
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/2357#discussion_r74439866
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rpc/akka/messages/RpcInvocation.java
---
@@ -0,0 +1,98 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.rpc.akka.messages;
+
+import org.apache.flink.util.Preconditions;
+
+import java.io.IOException;
+import java.io.ObjectInputStream;
+import java.io.ObjectOutputStream;
+import java.io.Serializable;
+
+/**
+ * Rpc invocation message containing the remote procedure name, its
parameter types and the
+ * corresponding call arguments.
+ */
+public final class RpcInvocation implements Serializable {
+ private static final long serialVersionUID = -7058254033460536037L;
+
+ private final String methodName;
+ private final Class<?>[] parameterTypes;
--- End diff --
Similar as giving a better exception on non-serializable types, we can try
and give a better exception on Classes that are not part of the system class
loader.
The current Akka behavior (dropping the message) was always a bit to
silent. Sending back an exception could help catching these things more easily.
> Auto generate message sender classes via Java Proxies
> -----------------------------------------------------
>
> Key: FLINK-4362
> URL: https://issues.apache.org/jira/browse/FLINK-4362
> Project: Flink
> Issue Type: Sub-task
> Components: Distributed Coordination
> Reporter: Stephan Ewen
> Assignee: Till Rohrmann
>
> The first version of the RPC service needs to manually create the sender
> classes, which turn method calls into messages.
> This can be automated by using Java Proxies.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
