XComp commented on a change in pull request #18692:
URL: https://github.com/apache/flink/pull/18692#discussion_r806086781
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/FileSystemJobResultStore.java
##########
@@ -52,7 +52,18 @@
*/
public class FileSystemJobResultStore extends AbstractThreadsafeJobResultStore
{
- private static final String DIRTY_SUFFIX = "_DIRTY";
+ @VisibleForTesting static final String FILE_EXTENSION = ".json";
+ @VisibleForTesting static final String DIRTY_FILE_EXTENSION = "_DIRTY" +
FILE_EXTENSION;
+
+ @VisibleForTesting
+ public static boolean hasValidDirtyJobResultStoreEntryExtension(String
filename) {
+ return filename.endsWith(DIRTY_FILE_EXTENSION);
+ }
+
+ @VisibleForTesting
+ public static boolean hasValidJobResultStoreEntryExtension(String
filename) {
+ return filename.endsWith(FILE_EXTENSION);
Review comment:
The constants I use in the `FileSystemJobResultStoreTest` as well. But I
kept them `package-private`. The `hasValid*` can be used in other places like
the `HAJobRunOnMinioS3StoreITCase` and are, therefore, `public`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
