XComp commented on a change in pull request #18749:
URL: https://github.com/apache/flink/pull/18749#discussion_r806574368
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/JobManagerMetricGroup.java
##########
@@ -38,7 +39,7 @@
* tasks any more
*/
public class JobManagerMetricGroup extends
ComponentMetricGroup<JobManagerMetricGroup>
- implements LocallyCleanableResource {
+ implements LocallyCleanableResource, GloballyCleanableResource {
Review comment:
That's actually a cleaner approach I haven't thought of. That would also
apply to the `JobManagerRunnerRegistry`. It makes sense because the
`DispatcherResourceCleanerFactory` is more closely tight to the `Dispatcher`. I
will adapt the PR accordingly and update the JavaDoc to fit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
