[
https://issues.apache.org/jira/browse/FLINK-26161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yufei Zhang closed FLINK-26161.
-------------------------------
Resolution: Invalid
When I look back at this issue, I think I had some misunderstanding at the
beginning. If the partitionSplit is empty, it will still enter the for loop. It
is empty at the beginning does not mean it will always be empty during the
polling. I'll close this issue.
> Pulsar Connector: edge case: splits should be added to finishedSplits if was
> empty from beginning
> -------------------------------------------------------------------------------------------------
>
> Key: FLINK-26161
> URL: https://issues.apache.org/jira/browse/FLINK-26161
> Project: Flink
> Issue Type: Bug
> Components: Connectors / Pulsar
> Reporter: Yufei Zhang
> Priority: Minor
> Labels: Pulsar
>
> Currently we add a split to finishedSplit in the read for loop, but if the
> split is empty and never enters for loop it should be checked whether to add
> to finishedSplit as well. This is an edge case and priority is low.
>
> {{// current code}}
> {{ if (stopCursor.shouldStop(message)) {
> builder.addFinishedSplit(splitId); break;
> }}}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
