zentol edited a comment on pull request #18692:
URL: https://github.com/apache/flink/pull/18692#issuecomment-1040251026


   > We do. The Presto S3 Filesystem requires it. That's what 
[FLINK-26061](https://issues.apache.org/jira/browse/FLINK-26061) is about.
   
   I'm wondering if that isn't yet again a minio issue. From everything I have 
read presto assumes that everything is an empty directory by default (hence why 
mkdirs doesn't do anything). So unless you check that a directory does _not_ 
exist things should be fine. 
https://hadoop.apache.org/docs/stable/hadoop-aws/tools/hadoop-aws/directory_markers.html
   
   Did you step through PrestoS3FileSystem to see which call fails? How does 
the test (FileSystemBehaviorTestSuite.testMkdirsCreatesParentDirectories) 
actually fail? Is the assertion failing, or is the FS throwing a 
FileNotFoundException.
   I'm asking because FileSystem#exists only checks whether getFileStatus 
returns null, but I don't see a codepath in the presto filesystem where that 
can be the case.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to