tillrohrmann commented on a change in pull request #301: URL: https://github.com/apache/flink-statefun/pull/301#discussion_r806575847
########## File path: statefun-sdk-python/README.md ########## @@ -17,7 +17,7 @@ to get yourself started with Stateful Functions in Python. For a fully detailed documentation, please visit the [official docs](https://ci.apache.org/projects/flink/flink-statefun-docs-master). -For code examples, please take a look at the [examples](../statefun-examples/). +For code examples, please take a look at the [examples](https://github.com/apache/flink-statefun-playground/tree/dev/python). Review comment: I think the latest release branch makes sense since it is also what is shown for a specific PyPI package. ########## File path: statefun-sdk-python/README.md ########## @@ -17,7 +17,7 @@ to get yourself started with Stateful Functions in Python. For a fully detailed documentation, please visit the [official docs](https://ci.apache.org/projects/flink/flink-statefun-docs-master). -For code examples, please take a look at the [examples](../statefun-examples/). +For code examples, please take a look at the [examples](https://github.com/apache/flink-statefun-playground/tree/dev/python). Review comment: What is not so optimal is that updating these links is currently a manual process. As a follow-up we might wanna think about how this could be automated by establishing a branch mapping between `flink-statefun` and `flink-statefun-playground`. ########## File path: statefun-sdk-python/README.md ########## @@ -17,7 +17,7 @@ to get yourself started with Stateful Functions in Python. For a fully detailed documentation, please visit the [official docs](https://ci.apache.org/projects/flink/flink-statefun-docs-master). -For code examples, please take a look at the [examples](../statefun-examples/). +For code examples, please take a look at the [examples](https://github.com/apache/flink-statefun-playground/tree/dev/python). Review comment: I think `main` is good. In `release-3.2` I will change it to point to `release-3.2`. ########## File path: statefun-sdk-python/README.md ########## @@ -17,7 +17,7 @@ to get yourself started with Stateful Functions in Python. For a fully detailed documentation, please visit the [official docs](https://ci.apache.org/projects/flink/flink-statefun-docs-master). -For code examples, please take a look at the [examples](../statefun-examples/). +For code examples, please take a look at the [examples](https://github.com/apache/flink-statefun-playground/tree/dev/python). Review comment: I think `main` is good. In `release-3.2` I will change it to point to `[release-3.2](https://github.com/apache/flink-statefun-playground/tree/release-3.2/python)`. ########## File path: statefun-sdk-python/README.md ########## @@ -17,7 +17,7 @@ to get yourself started with Stateful Functions in Python. For a fully detailed documentation, please visit the [official docs](https://ci.apache.org/projects/flink/flink-statefun-docs-master). -For code examples, please take a look at the [examples](../statefun-examples/). +For code examples, please take a look at the [examples](https://github.com/apache/flink-statefun-playground/tree/dev/python). Review comment: ~~I think `main` is good. In `release-3.2` I will change it to point to `https://github.com/apache/flink-statefun-playground/tree/release-3.2/python`.~~ Pointing to `main` is also not optimal because no examples are contained in this branch. If we pointed to `main`, then we would have to add the specific relative path to the actual examples with every release. Hence, I will let it point to `release-3.2` instead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
