autophagy commented on a change in pull request #18678:
URL: https://github.com/apache/flink/pull/18678#discussion_r806935197
##########
File path:
flink-end-to-end-tests/flink-end-to-end-tests-common/src/main/java/org/apache/flink/tests/util/flink/container/FlinkContainersBuilder.java
##########
@@ -163,6 +163,7 @@ public FlinkContainers build() {
this.conf.set(
CheckpointingOptions.CHECKPOINTS_DIRECTORY,
CHECKPOINT_PATH.toAbsolutePath().toUri().toString());
+ this.conf.set(RestOptions.BIND_ADDRESS, "0.0.0.0");
Review comment:
Yes. Would it be better to just unset the parameter rather than hardcode
it to `0.0.0.0`?
##########
File path:
flink-end-to-end-tests/flink-end-to-end-tests-common/src/main/java/org/apache/flink/tests/util/flink/container/FlinkContainersBuilder.java
##########
@@ -163,6 +163,7 @@ public FlinkContainers build() {
this.conf.set(
CheckpointingOptions.CHECKPOINTS_DIRECTORY,
CHECKPOINT_PATH.toAbsolutePath().toUri().toString());
+ this.conf.set(RestOptions.BIND_ADDRESS, "0.0.0.0");
Review comment:
Yes. Would it be better to just unset the option rather than hardcode it
to `0.0.0.0`?
##########
File path:
flink-end-to-end-tests/flink-end-to-end-tests-common/src/main/java/org/apache/flink/tests/util/flink/container/FlinkContainersBuilder.java
##########
@@ -163,6 +163,7 @@ public FlinkContainers build() {
this.conf.set(
CheckpointingOptions.CHECKPOINTS_DIRECTORY,
CHECKPOINT_PATH.toAbsolutePath().toUri().toString());
+ this.conf.set(RestOptions.BIND_ADDRESS, "0.0.0.0");
Review comment:
I mostly did it this way to mimic what we do on flink-docker, which was
set it explicitly to `0.0.0.0`.
##########
File path:
flink-end-to-end-tests/flink-end-to-end-tests-common/src/main/java/org/apache/flink/tests/util/flink/container/FlinkContainersBuilder.java
##########
@@ -163,6 +163,7 @@ public FlinkContainers build() {
this.conf.set(
CheckpointingOptions.CHECKPOINTS_DIRECTORY,
CHECKPOINT_PATH.toAbsolutePath().toUri().toString());
+ this.conf.set(RestOptions.BIND_ADDRESS, "0.0.0.0");
Review comment:
Yes. Would it be better to just unset the option rather than hardcode it
to `0.0.0.0`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
