imaffe commented on a change in pull request #18406:
URL: https://github.com/apache/flink/pull/18406#discussion_r808943898
##########
File path:
flink-connectors/flink-connector-pulsar/src/test/java/org/apache/flink/connector/pulsar/source/reader/deserializer/PulsarDeserializationSchemaTest.java
##########
@@ -108,6 +122,243 @@ void createFromFlinkTypeInformation() throws Exception {
assertEquals(collector.result, "test-content");
}
+ @Test
+ void primitiveStringPulsarSchema() {
+ final String topicName =
+ "primitiveString-" + ThreadLocalRandom.current().nextLong(0,
Long.MAX_VALUE);
+ operator().createTopic(topicName, 1);
+ String expectedMessage = randomAlphabetic(10);
+ operator()
+ .sendMessage(
+ TopicNameUtils.topicNameWithPartition(topicName, 0),
+ Schema.STRING,
+ expectedMessage);
+ PulsarSource<String> source = createSource(topicName,
pulsarSchema(Schema.STRING));
+ assertThatCode(() -> runPipeline(source,
expectedMessage)).doesNotThrowAnyException();
Review comment:
Here I thought no exception could prove the deserialization is ok, do we
need to verify that the records are intact as well ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
