Github user wuchong commented on a diff in the pull request: https://github.com/apache/flink/pull/2371#discussion_r74720168 --- Diff: flink-core/src/test/java/org/apache/flink/configuration/DelegatingConfigurationTest.java --- @@ -88,4 +89,51 @@ private String typeParamToString(Class<?>[] classes) { assertTrue("Foo method '" + configurationMethod.getName() + "' has not been wrapped correctly in DelegatingConfiguration wrapper", hasMethod); } } + + @Test + public void testDelegationConfigurationWithNullPrefix() { + + Configuration backingConf = new Configuration(); + backingConf.setValueInternal("test-key", "value"); + + DelegatingConfiguration configuration = new DelegatingConfiguration( + backingConf, null); + Set<String> keySet = configuration.keySet(); + + assertTrue(keySet.equals(backingConf.keySet())); --- End diff -- minor, it's better to use `assertEquals(keySet, backingConf.keySet())` here I think. Below is the same
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---