[ 
https://issues.apache.org/jira/browse/FLINK-26216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17494984#comment-17494984
 ] 

ConradJam edited comment on FLINK-26216 at 2/20/22, 6:04 AM:
-------------------------------------------------------------

Hi [~bgeng777] , I have read your reply,and I see that you have completed an 
important
part. I have also done the verification operation based on this code

If the number of copies set by the user is greater than 1, I will enter 
FlinkConfig to check whether the user has enabled the high availability option. 
This parameter will take effect only when enabled. Otherwise, I will throw an 
exception indicating that the deployment verification fails, indicating that 
the user must configure high availability. This parameter takes effect only 
when the user configuration is greater than 1 and high availability is enabled. 
I'm doing an intercept in front, and I don't know if it's necessary. If it is 
not intercepted here, it will be checked by Flink at deployment time and then 
an exception will be thrown. Which method do you think is more suitable ?


was (Author: JIRAUSER285483):
Hi, I have read your reply,and I see that you have completed an important
part. I have also done the verification operation based on this code, and
you can assign it to me. This part is a more perfect operation

Biao Geng (Jira) <j...@apache.org> 于 2022年2月19日周六 下午10:31写道:



> Make 'replicas' work in JobManager Spec
> ---------------------------------------
>
>                 Key: FLINK-26216
>                 URL: https://issues.apache.org/jira/browse/FLINK-26216
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Kubernetes Operator
>            Reporter: Biao Geng
>            Priority: Minor
>
> In our flink kubernetes operator's cr, we allow users to set the replica of 
> JobManager. 
> But in our {{FlinkUtils#getEffectiveConfig}} method, we currently not set 
> this value from the yaml file and as a result, the {{replicas}} will not work 
> and the default value(i.e. 1) will be applied. 
> Though we believe one JM with KubernetesHaService should be enough for most 
> HA cases, the {{replicas}} field of JM also makes sense since more than one 
> JM can reduce down time and make recovery of JM failure faster. 



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to