Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2313#discussion_r74757794
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/client/JobClientActor.java
---
@@ -198,10 +211,47 @@ else if (message instanceof SubmitJobAndWait) {
decorateMessage(new Status.Failure(new
Exception(msg))), ActorRef.noSender());
}
}
+ else if (message instanceof AttachToJobAndWait) {
--- End diff --
This branch looks like sharing a lot of code with the branch above. I
wonder if there's a way to generalize the code into a method?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
