2011aad commented on a change in pull request #18822:
URL: https://github.com/apache/flink/pull/18822#discussion_r810902963



##########
File path: 
flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/internal/JdbcOutputFormat.java
##########
@@ -154,7 +154,9 @@ public void open(int taskNumber, int numTasks) throws 
IOException {
                                         try {
                                             flush();
                                         } catch (Exception e) {
-                                            flushException = e;
+                                            if (flushException == null) {

Review comment:
       I think here is the situation that we only need to store the original 
exception. Since the following exceptions are all  produced by 
`checkFlushException()` with no further information. 
   So, I think it is ok to just ignore the following exceptions without 
suppress them.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to